Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue330 #335

Closed
wants to merge 3 commits into from
Closed

Issue330 #335

wants to merge 3 commits into from

Conversation

qlli
Copy link
Contributor

@qlli qlli commented Sep 20, 2024 •
edited
Loading

When the game starts and analyses the var definition in main.spx,
the sprite is automatically bound if assets/sprites/{name}/index.json exists,
and the sound is automatically bound if assets/sounds/{name}/index.json exists.
No effect on the sprites and sounds in ZOrder of stage config.
Archive.zip

@qiniu-x qiniu-x
Copy link
Contributor

qiniu-x bot commented Sep 20, 2024

[Git-flow] Hi @qlli, There are some suggestions for your information:

Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'goplus:main' into main

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

nighca
nighca reviewed Sep 20, 2024
View reviewed changes
sprite.go
@@ -494,6 +494,7 @@ func (p *Sprite) Die() {
p.goAnimate(aniName, ani)
}

p.Stop(OtherScriptsInSprite)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要 rebase 下 goplus/main？

@JiepengTan
Copy link
Collaborator

JiepengTan commented Sep 20, 2024 •
edited
Loading

52e4164d-22c2-478f-a70d-ba496848f38c

@qlli

var (
    explosion Sound
    myNiuXiaoQi NiuXiaoQi
)

onClick => {
    NiuXiaoQi.hide
    play explosion
}

@nighca "NiuXiaoQi.hide " This might require compiler support. Are you sure you allow users to write this kind of code?

@JiepengTan JiepengTan self-requested a review September 20, 2024 04:01
JiepengTan
JiepengTan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@JiepengTan JiepengTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use rebase instead of merge to synchronize the changes from the remote main branch.

JiepengTan
JiepengTan reviewed Sep 20, 2024
View reviewed changes
game.go
@@ -354,6 +358,17 @@ func (p *Game) startLoad(fs spxfs.Dir, cfg *Config) {
p.windowHeight_ = cfg.Height
}

func (p *Game) canBindSprite(sprite Spriter, name string) bool {
Copy link
Collaborator

@JiepengTan JiepengTan Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sprite Spriter" this param is useless, remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Done in pr 336.
#336
The pr 335 contains other unexpected commit.
Use pr 336 instead.

@qlli qlli closed this by deleting the head repository Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nighca nighca nighca left review comments

@JiepengTan JiepengTan JiepengTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qlli @JiepengTan @nighca